Skip to content
This repository has been archived by the owner on Jan 26, 2018. It is now read-only.

Support OWNERS file #20

Closed
benhutchins opened this issue Jun 1, 2016 · 3 comments
Closed

Support OWNERS file #20

benhutchins opened this issue Jun 1, 2016 · 3 comments

Comments

@benhutchins
Copy link

While a MAINTAINERS is good, this doesn't work very well for all projects. Many projects therefore use OWNERS files, which sometimes works by being placed in any folder to define the owners of that portion of a codebase or by using pathing within an OWNERS file to specify which paths they own.

https://github.com/bkeepers/OWNERS implements a pathing based top-level OWNERS file.

Realistically this could be merged with the existing support for the MAINTAINERS file, just need to use the Toml-style file and add support for defining a path or specifying file matching patterns (like *.js).

This would dramatically help improve the usability of LGTM, requiring changes to specific sections of the codebase to be signed off may result in several required sign offs which is ideal.

@bradrydzewski
Copy link
Member

bradrydzewski commented Jun 1, 2016

I would be open to adding the following fields to the .lgtm file:

from = "bkeepers/OWNERS"
path = "OWNERS"

The from field would suggest an alternate repository name from which to fetch the maintainers file. The path file would suggest an alternate path / filename.

Please note that I'm not personally fulfilling feature requests for the project, however, if you are willing to send a pull request based on the above recommended implementation it is something I'm open to merging.

@bradrydzewski
Copy link
Member

bradrydzewski commented Jun 1, 2016

Realistically this could be merged with the existing support for the MAINTAINERS file, just need to use the Toml-style file and add support for defining a path or specifying file matching patterns (like *.js).

Sorry I forget to comment on this part. Please see the following section of the README
https://github.com/lgtmco/lgtm#development

If you are looking to extend LGTM to notify maintainers based on file type and matching patterns you might want to fork the project (feel free to rebrand as well). I published the source mostly so others could fork and extend as opposed to growing the LGTM feature set.

@bradrydzewski
Copy link
Member

I'm closing this in favor of pluggable algorithms
#32

I would prefer to expose the ability to delegate custom approval workflows to a plugin / webhook as opposed to including varying approval workflows / algorithms in the main codebase.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants