-
Notifications
You must be signed in to change notification settings - Fork 124
Support OWNERS file #20
Comments
I would be open to adding the following fields to the
The Please note that I'm not personally fulfilling feature requests for the project, however, if you are willing to send a pull request based on the above recommended implementation it is something I'm open to merging. |
Sorry I forget to comment on this part. Please see the following section of the README If you are looking to extend LGTM to notify maintainers based on file type and matching patterns you might want to fork the project (feel free to rebrand as well). I published the source mostly so others could fork and extend as opposed to growing the LGTM feature set. |
I'm closing this in favor of pluggable algorithms I would prefer to expose the ability to delegate custom approval workflows to a plugin / webhook as opposed to including varying approval workflows / algorithms in the main codebase. |
While a
MAINTAINERS
is good, this doesn't work very well for all projects. Many projects therefore useOWNERS
files, which sometimes works by being placed in any folder to define the owners of that portion of a codebase or by using pathing within anOWNERS
file to specify which paths they own.https://github.com/bkeepers/OWNERS implements a pathing based top-level
OWNERS
file.Realistically this could be merged with the existing support for the
MAINTAINERS
file, just need to use the Toml-style file and add support for defining a path or specifying file matching patterns (like*.js
).This would dramatically help improve the usability of LGTM, requiring changes to specific sections of the codebase to be signed off may result in several required sign offs which is ideal.
The text was updated successfully, but these errors were encountered: