Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__version__ for __mappy__ #165

Closed
jbloom opened this issue May 18, 2018 · 2 comments
Closed

__version__ for __mappy__ #165

jbloom opened this issue May 18, 2018 · 2 comments

Comments

@jbloom
Copy link

jbloom commented May 18, 2018

Would it be possible to add a __version__ string (e.g., mappy.__version__)? This is the standard way of accessing version numbers for Python modules / packages:
https://www.python.org/dev/peps/pep-0396/

This would facilitate writing larger Python packages that use mappy as a dependency.

@lh3
Copy link
Owner

lh3 commented May 18, 2018

Could you send a pull request? Thanks.

@1pakch
Copy link
Contributor

1pakch commented Jun 6, 2018

I can expose a version from here

#define MM_VERSION "2.10-r784-dirty"

as a LooseVersion as per PEP-386.

I am not sure how well this versioning scheme would integrate with the Python packaging ecosystem though.

@lh3 lh3 closed this as completed in e9ca0c9 Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants