Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Status #1090

Closed
19 of 22 tasks
tivac opened this issue Jun 3, 2016 · 16 comments
Closed
19 of 22 tasks

Rewrite Status #1090

tivac opened this issue Jun 3, 2016 · 16 comments
Milestone

Comments

@tivac
Copy link
Contributor

tivac commented Jun 3, 2016

Let's have a single place to track the rewrite status!

(As best as I can figure it at least, some things are still just stored in @lhorie's head 😄)

Alpha

Beta

NOTE: This isn't an issue for discussing API design/rewrite bugs/etc, those should happen in their own more focused issues.

@tivac tivac added the rewrite label Jun 3, 2016
@MithrilJS MithrilJS locked and limited conversation to collaborators Jun 3, 2016
@MithrilJS MithrilJS unlocked this conversation Jun 3, 2016
This was referenced Jun 3, 2016
@dead-claudia dead-claudia added this to the Rewrite milestone Jun 18, 2016
@dead-claudia
Copy link
Member

dead-claudia commented Jun 18, 2016

@tivac @lhorie I added a Rewrite milestone to help better categorize things, and I've added them to several existing issues. Welcome.

@lhorie
Copy link
Member

lhorie commented Jun 20, 2016

Update: major breaking change: promises are now gone in favor of streams. See docs for m.prop for more details on how streams work

@nordfjord
Copy link
Contributor

@lhorie would love to see more "Array" methods on the streams.

e.g. forEach, filter, reduce

let userStream = m.prop()
  .filter(user => user.isVisibleOnline)
  .forEach(user => {
    displayUserLoginPopup(user);
  });

subscribeToUserChannel(userStream);

@tinchoz49
Copy link

Yes i aggree with @nordfjord and maybe if the streams has an API compatible for example with the flyd streams we can extend the methods using their modules (filter, lift, flatmap...) without increase the size and the API stream functions in mithril.

BTW: great idea add the stream support. 👍 🚀

@darsain
Copy link
Contributor

darsain commented Jun 20, 2016

@lhorie if it's a breaking change already, why make it ambiguous by still calling it m.prop? Just name it m.stream :)

@dead-claudia
Copy link
Member

@darsain It's still mostly the old m.prop. Just instead of incorporating itself with Promises, it's incorporating itself into the Streams world (which also helps observability).

@pietermartin
Copy link

Any more info regarding the status of the rewrite.
We are planning on rewriting a large Angular 1 app and Mithril looks great but alas the status?

@lhorie
Copy link
Member

lhorie commented Nov 8, 2016

@pietermartin it's currently at release candidate 2

@lhorie
Copy link
Member

lhorie commented Dec 1, 2016

update: taking these out:

- [ ] #618 - ES6 classes as components
- [ ] `m.startComputation()` & `m.endComputation()`

@kylebakerio
Copy link

Migration guide link is dead.
link to docs for m.prop discussing breaking change to streams is dead.

@tivac
Copy link
Contributor Author

tivac commented Jan 5, 2017

Closing this as rewrite status is being tracked by the milestone now.

@tivac tivac closed this as completed Jan 5, 2017
@gyandeeps
Copy link
Contributor

"IE perf improvements" was marked done but I don't see it in the code. Am I missing something or was it dropped from the plan?

@tivac
Copy link
Contributor Author

tivac commented Jan 31, 2017

@gyandeeps Hmm, might've gotten lost in a re-shuffle. Would you be willing to open a new PR? 😞

@gyandeeps
Copy link
Contributor

@tivac I am loaded with work currently, i can when i get some time but meanwhile if somebody else wnat to do it feel free.

More details:

Here is the previous PR: #1016
Issue comment: #199 (comment)

This should give enough information.

Theme: Add the element to its parent before you add its children to it. this has perf imrovments on IE engines.

@gyandeeps
Copy link
Contributor

@tivac Spent some time today to get this work: #1598

@lhorie
Copy link
Member

lhorie commented Feb 9, 2017

added some love for @gyandeeps : http://mithril.js.org/credits.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants