-
-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularize with ES2015 and rollupjs #913
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You know, for fun. 🎉
And add m.component
Also re-order and actually call initialize
(The test claiming it is passing is a lie, ignore it) |
Plus a minor formatting fix.
To be honest, modularizing is something I'm doing w/ the rewrite, so I don't know if it's worth putting a lot of effort in modularizing the current codebase |
Fair enough, I know I've asked before but I'd love to see your work on the rewrite! 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to take a crack at the modularity dragon using ES2015 modules and rollupjs.
So here it is. This supports the entire current mithril API in theory, though there's a bunch of failing tests that I'll need to fix. Sending this to generate discussion and ensure this is an approach that is worth pursuing further.
I also cleaned up most of the ESLint issues in
mithril.js
during the process, but to keep from going crazy I modified the.eslintrc
to make it better match the reality of the library. I'm not sure if those settings are aspirational or what but they seem totally at odds with the code as it is. In order to rewrite as little code as possible I've side-stepped that issue for now.It's a little premature to talk end-user size, but after uglifying and gzipping this version of mithril ends up comparable in size to
v0.2.2-rc1
. 👍TODO
This is related to #651, #665, and #802.