Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

espnet example? #171

Closed
danpovey opened this issue Dec 30, 2020 · 6 comments
Closed

espnet example? #171

danpovey opened this issue Dec 30, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@danpovey
Copy link
Collaborator

I have been following espnet https://github.com/espnet/espnet and they are open to new recipes, they have merged a couple in the last week or so. I think lhotse+espnet would be a good combination because Shinji's real interest is, I think, in end-to-end architectures and abstracting away the data-prep may appeal to him.
Would also be a good opportunity to tune things like data augmentation recipes.

@pzelasko
Copy link
Collaborator

I agree. I talked with Shinji some time ago and I think he was interested to explore that. @sw005320 WDYT?

Actually I think the discussion in PR #172 could be relevant in the context of ESPnet too.

@pzelasko pzelasko added the enhancement New feature or request label Dec 30, 2020
@sw005320
Copy link

Yes, this is very cool.
I don't fully follow #172, but #149 would be a good way to use the lhotse data preparation.
@pzelasko, in #149, you mentioned that it was intended to build a Kaldi system.
Then, do you have a Kaldi nsc recipe with lhotse-based data preparation?
Then, I think I can make an nsc recipe in espnet through lhotse-based data preparation.

@pzelasko
Copy link
Collaborator

Yeah, I have a Kaldi NSC recipe here: https://github.com/pzelasko/kaldi/tree/feature/nsc-recipe/egs/nsc/s5

However, it is not well-tuned - I simply replicated the LibriSpeech recipe as it has a similar amount of data, and got about 31% WER on a held-out, unofficial test set (I don't think there is an official one).

@sw005320
Copy link

sw005320 commented Jan 5, 2021

I just made an NSC recipe by using the lhotse data preparation in espnet espnet/espnet#2846
It seems to be working.
I think this is a good practice as an initial point.

@pzelasko
Copy link
Collaborator

pzelasko commented Jan 5, 2021

Cool!

Going forward, would you be interested to explore using Lhotse's Python API? You can see an example in snowfall's librispeech recipe here and then K2 training uses a dedicated Dataset class here (I could help with writing the Dataset class, I'm actually trying to figure out what is the right way to make a generic template or a set of utilities for that to support many tasks)

As Dan mentioned that'd definitely help us add and tune relevant features like data augmentation, etc.

@pzelasko
Copy link
Collaborator

Resolved by #384 (there is a colab notebook link with an example of Lhotse + ESPnet integration)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants