Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

musicPathXML and musicPathSystem? #53

Open
shacker opened this issue Jun 24, 2017 · 2 comments
Open

musicPathXML and musicPathSystem? #53

shacker opened this issue Jun 24, 2017 · 2 comments

Comments

@shacker
Copy link
Collaborator

shacker commented Jun 24, 2017

Library.py references these two objects, but it is unclear where they're supposed to be passed in from or what they do. Comments say:

        # musicPathXML and musicPathSystem will do path conversion
        # when xml is being processed on different OS then iTunes

iTunes is not an OS. I can't make any sense of this. If no one objects I'd like to delete these references.

@liamks
Copy link
Owner

liamks commented Jun 25, 2017

It's possible they meant "when xml is being processed on a different OS than MacOS"? If the objects aren't being used anymore they can probably be removed. Could be a relic from when libpytunes did it's own XML parsing.

@shacker
Copy link
Collaborator Author

shacker commented Jun 26, 2017

OK I'll wait until #52 lands and then remove this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants