Skip to content

Commit 3978289

Browse files
committed
fix(create): install TNS as a dev dependency
1 parent 8ff1a2f commit 3978289

File tree

1 file changed

+21
-22
lines changed

1 file changed

+21
-22
lines changed

scripts/create.js

Lines changed: 21 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,13 @@ const createApp = (appName, useYarn) => {
2828
},
2929
}
3030

31-
const packageDependencies = ['typescript-node-scripts']
31+
// const packageDependencies = ['typescript-node-scripts']
3232
const packageDevDependencies = [
3333
'@types/node',
3434
'@types/jest',
35-
'typescript',
3635
'tslint',
36+
'typescript',
37+
'typescript-node-scripts',
3738
]
3839

3940
// check if the path exists
@@ -63,22 +64,20 @@ const createApp = (appName, useYarn) => {
6364
// install package dependencies
6465
console.log(
6566
'Installing ' +
66-
[...packageDependencies, ...packageDevDependencies]
67-
.map(i => chalk.cyan(i))
68-
.join(', ')
67+
[...packageDevDependencies].map(i => chalk.cyan(i)).join(', ')
6968
)
7069

7170
let cmd
72-
let dependencyArgs
71+
// let dependencyArgs
7372
let devDependencyArgs
7473

7574
if (useYarn) {
7675
cmd = 'yarnpkg'
77-
dependencyArgs = ['add', ...packageDependencies]
76+
// dependencyArgs = ['add', ...packageDependencies]
7877
devDependencyArgs = ['add', ...packageDevDependencies, '--dev']
7978
} else {
8079
cmd = 'npm'
81-
dependencyArgs = ['install', '--save', ...packageDependencies]
80+
// dependencyArgs = ['install', '--save', ...packageDependencies]
8281
devDependencyArgs = ['install', '--save-dev', ...packageDevDependencies]
8382
}
8483

@@ -99,20 +98,20 @@ const createApp = (appName, useYarn) => {
9998
}
10099

101100
// install dependencies
102-
const dependencyProc = spawn(cmd, dependencyArgs, {
103-
stdio: 'inherit',
104-
cwd: appPath,
105-
})
106-
if (dependencyProc.status !== 0) {
107-
console.error()
108-
console.error(
109-
chalk.red('Command'),
110-
chalk.redBright(`'${cmd} ${dependencyArgs.join(' ')}'`),
111-
chalk.red('failed.')
112-
)
113-
console.error()
114-
process.exit(1)
115-
}
101+
// const dependencyProc = spawn(cmd, dependencyArgs, {
102+
// stdio: 'inherit',
103+
// cwd: appPath,
104+
// })
105+
// if (dependencyProc.status !== 0) {
106+
// console.error()
107+
// console.error(
108+
// chalk.red('Command'),
109+
// chalk.redBright(`'${cmd} ${dependencyArgs.join(' ')}'`),
110+
// chalk.red('failed.')
111+
// )
112+
// console.error()
113+
// process.exit(1)
114+
// }
116115

117116
// initialize git repo
118117
try {

0 commit comments

Comments
 (0)