Skip to content

Don't minify on production build / Provide option to enable minification #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
liangchunn opened this issue Jul 31, 2019 · 1 comment
Closed

Don't minify on production build / Provide option to enable minification #132

liangchunn opened this issue Jul 31, 2019 · 1 comment
Assignees
@liangchunn
Labels
next

Comments

@liangchunn
Copy link
Owner

liangchunn commented Jul 31, 2019 •
edited
Loading

Description
Minifying the output source can sometimes lead to problems like mangling of class names, which causes calls to Function.name to break. An example is using TypeORM, which relies on class names to find circular dependencies: typeorm/typeorm#2549 (comment)

Acceptance Criteria

  • An option is provided to enable minification
  • Minification is disabled by default
@liangchunn liangchunn added the bug Something isn't working label Jul 31, 2019
@liangchunn liangchunn added next and removed bug Something isn't working labels Aug 7, 2019
@liangchunn liangchunn self-assigned this Aug 7, 2019
@liangchunn
Copy link
Owner Author

Packages should not rely on function names to define runtime behaviour. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liangchunn liangchunn

Labels
next
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@liangchunn