Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - there is no need to set getOrNil on RedisService, if none provided, an error must be thrown #558

Open
jserfun opened this issue Dec 23, 2024 · 0 comments
Open

Bug - there is no need to set getOrNil on RedisService, if none provided, an error must be thrown #558

jserfun opened this issue Dec 23, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jserfun
Copy link

jserfun commented Dec 23, 2024

Describe the bug

getOrNil may confuse developer, it just try to connect redis client, but in my opinion, it may disguide people on redis client methods, and then throw error

Steps to reproduce

None

Expected behavior

rm getOrNil

Environment

Any

Additional context

None
@jserfun jserfun added the bug Something isn't working label Dec 23, 2024
@jserfun jserfun changed the title Bug - there is no need to set getOrNil on RedisService, if none provided, a error must be thrown Bug - there is no need to set getOrNil on RedisService, if none provided, an error must be thrown Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jserfun