Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: lib/pq
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.10.6
Choose a base ref
...
head repository: lib/pq
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.10.9
Choose a head ref
  • 12 commits
  • 11 files changed
  • 8 contributors

Commits on May 25, 2022

  1. Use pointer receiver on pq.Error.Error()

    The library returns *pq.Error and not pq.Error.
    
    By using a value receiver, the library was documenting that consumers
    should expect returned error values to contain pq.Error.
    
    While *pq.Error implements all methods on pq.Error, *pq.Error is not
    assignable to pq.Error and so you can't type assert an error value into
    pq.Error if it actually contains *pq.Error.
    
    In particular, this is a problem with errors.As. The following if
    condition will always return false.
    
        var pqe pq.Error
        if errors.As(err, &pqe) {
          // Never reached as *pq.Error is not assignable to pqe.
          ...
        }
    nhooyr committed May 25, 2022

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    nhooyr Anmol Sethi
    Copy the full SHA
    89fee89 View commit details

Commits on Aug 30, 2022

  1. Set SNI for TSL connections

    This allows an SNI-aware proxy to route connections. Patch adds a new
    connection option (`sslsni`) for opting out of the SNI, to have the same
    behavior as `libpq` does. See more in `sslsni` sections at
    <https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-PARAMKEYWORDS>.
    kelvich committed Aug 30, 2022
    Copy the full SHA
    957fc0b View commit details

Commits on Sep 6, 2022

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    d65e6ae View commit details
  2. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    d5affd5 View commit details

Commits on Jan 24, 2023

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    133ac67 View commit details
  2. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    3a6282f View commit details
  3. Update test.yml

    otan authored Jan 24, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    a2a3173 View commit details
  4. Update codeql-analysis.yml

    otan authored Jan 24, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    922c00e View commit details

Commits on Apr 14, 2023

  1. conn: Implement driver.Validator, SessionResetter for cancelation

    Commit 8446d16 released in 1.10.4 changed how some cancelled query
    errors were returned. This has caused a lib/pq application I work on
    to start returning "driver: bad connection". This is because we were
    cancelling a query, after looking at some of the rows. This causes a
    "bad" connection to be returned to the connection pool.
    
    To prevent this, implement the driver.Validator and
    driver.SessionResetter interfaces. The database/sql/driver package
    recommends implementing them:
    
    "All Conn implementations should implement the following interfaces:
    Pinger, SessionResetter, and Validator"
    
    Add two tests for this behaviour. One of these tests passed with
    1.10.3 but fails with newer versions. The other never passed, but
    does after this change.
    evanj authored and rafiss committed Apr 14, 2023
    Copy the full SHA
    96e73eb View commit details
  2. remove stray debugging code

    evanj authored and rafiss committed Apr 14, 2023
    Copy the full SHA
    c10fcfe View commit details

Commits on Apr 26, 2023

  1. fix handle pgpass (#1120)

    acoshift authored Apr 26, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    d8d93a3 View commit details
  2. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    2a217b9 View commit details
Loading