Shorthand types must be used (#52)

Author: thewilkybarkid

src/Libero/ruleset.xml

@@ -127,6 +127,7 @@
         </properties>
     </rule>
     <rule ref="SlevomatCodingStandard.TypeHints.DisallowArrayTypeHintSyntax"/>
+    <rule ref="SlevomatCodingStandard.TypeHints.LongTypeHints"/>
     <rule ref="SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue"/>
     <rule ref="SlevomatCodingStandard.TypeHints.ParameterTypeHintSpacing"/>
     <rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHintSpacing">

tests/cases/classes/method-type-long

@@ -0,0 +1,97 @@
+---DESCRIPTION---
+Shorthand types must be used
+---FILENAME---
+Foo.php
+---CONTENTS---
+<?php
+
+declare(strict_types=1);
+
+namespace Vendor;
+
+class Foo
+{
+    /** @var integer */
+    public $foo;
+
+    /** @var boolean */
+    public $bar;
+
+    /** @var array<integer, boolean> */
+    public $baz;
+
+    /**
+     * @param integer $quux
+     *
+     * @return integer
+     */
+    public function qux($quux)
+    {
+    }
+
+    /**
+     * @param boolean $corge
+     *
+     * @return boolean
+     */
+    public function quuz($corge)
+    {
+    }
+
+    /**
+     * @param array<integer, boolean> $garply
+     *
+     * @return array<integer, boolean>
+     */
+    public function grault($garply)
+    {
+    }
+}
+
+---FIXED---
+<?php
+
+declare(strict_types=1);
+
+namespace Vendor;
+
+class Foo
+{
+    /** @var int */
+    public $foo;
+
+    /** @var bool */
+    public $bar;
+
+    /** @var array<int, bool> */
+    public $baz;
+
+    /**
+     * @param int $quux
+     *
+     * @return int
+     */
+    public function qux($quux)
+    {
+    }
+
+    /**
+     * @param bool $corge
+     *
+     * @return bool
+     */
+    public function quuz($corge)
+    {
+    }
+
+    /**
+     * @param array<int, bool> $garply
+     *
+     * @return array<int, bool>
+     */
+    public function grault($garply)
+    {
+    }
+}
+
+---

tests/cases/functions/type-long

@@ -0,0 +1,67 @@
+---DESCRIPTION---
+Shorthand types must be used
+---CONTENTS---
+<?php
+
+declare(strict_types=1);
+
+/**
+ * @param integer $bar
+ *
+ * @return integer
+ */
+function foo($bar)
+{
+}
+
+/**
+ * @param boolean $qux
+ *
+ * @return boolean
+ */
+function baz($qux)
+{
+}
+
+/**
+ * @param array<integer, boolean> $quuz
+ *
+ * @return array<integer, boolean>
+ */
+function quux($quuz)
+{
+}
+
+---FIXED---
+<?php
+
+declare(strict_types=1);
+
+/**
+ * @param int $bar
+ *
+ * @return int
+ */
+function foo($bar)
+{
+}
+
+/**
+ * @param bool $qux
+ *
+ * @return bool
+ */
+function baz($qux)
+{
+}
+
+/**
+ * @param array<int, bool> $quuz
+ *
+ * @return array<int, bool>
+ */
+function quux($quuz)
+{
+}
+
+---

tests/cases/interfaces/method-type-long

@@ -0,0 +1,67 @@
+---DESCRIPTION---
+Shorthand types must be used
+---FILENAME---
+Foo.php
+---CONTENTS---
+<?php
+
+declare(strict_types=1);
+
+namespace Vendor;
+
+interface Foo
+{
+    /**
+     * @param integer $baz
+     *
+     * @return integer
+     */
+    public function bar($baz);
+
+    /**
+     * @param boolean $quux
+     *
+     * @return boolean
+     */
+    public function qux($quux);
+
+    /**
+     * @param array<integer, boolean> $corge
+     *
+     * @return array<integer, boolean>
+     */
+    public function quuz($corge);
+}
+
+---FIXED---
+<?php
+
+declare(strict_types=1);
+
+namespace Vendor;
+
+interface Foo
+{
+    /**
+     * @param int $baz
+     *
+     * @return int
+     */
+    public function bar($baz);
+
+    /**
+     * @param bool $quux
+     *
+     * @return bool
+     */
+    public function qux($quux);
+
+    /**
+     * @param array<int, bool> $corge
+     *
+     * @return array<int, bool>
+     */
+    public function quuz($corge);
+}
+
+---

tests/cases/trait/method-type-long

@@ -0,0 +1,97 @@
+---DESCRIPTION---
+Shorthand types must be used
+---FILENAME---
+Foo.php
+---CONTENTS---
+<?php
+
+declare(strict_types=1);
+
+namespace Vendor;
+
+trait Foo
+{
+    /** @var integer */
+    public $foo;
+
+    /** @var boolean */
+    public $bar;
+
+    /** @var array<integer, boolean> */
+    public $baz;
+
+    /**
+     * @param integer $quux
+     *
+     * @return integer
+     */
+    public function qux($quux)
+    {
+    }
+
+    /**
+     * @param boolean $corge
+     *
+     * @return boolean
+     */
+    public function quuz($corge)
+    {
+    }
+
+    /**
+     * @param array<integer, boolean> $garply
+     *
+     * @return array<integer, boolean>
+     */
+    public function grault($garply)
+    {
+    }
+}
+
+---FIXED---
+<?php
+
+declare(strict_types=1);
+
+namespace Vendor;
+
+trait Foo
+{
+    /** @var int */
+    public $foo;
+
+    /** @var bool */
+    public $bar;
+
+    /** @var array<int, bool> */
+    public $baz;
+
+    /**
+     * @param int $quux
+     *
+     * @return int
+     */
+    public function qux($quux)
+    {
+    }
+
+    /**
+     * @param bool $corge
+     *
+     * @return bool
+     */
+    public function quuz($corge)
+    {
+    }
+
+    /**
+     * @param array<int, bool> $garply
+     *
+     * @return array<int, bool>
+     */
+    public function grault($garply)
+    {
+    }
+}
+
+---