Use PHPStan (#26)

Author: thewilkybarkid

.travis.yml

@@ -30,6 +30,11 @@ jobs:
           script:
               - vendor/bin/phpcs -p
 
+        - stage: Code Quality
+          env: STATIC_ANALYSIS
+          script:
+              - vendor/bin/phpstan analyse
+
 stages:
     - Test
     - name: Code Quality

composer.json

@@ -18,6 +18,8 @@
         "ext-mbstring": "*",
         "ext-tokenizer": "*",
         "lstrojny/functional-php": "^1.8",
+        "phpstan/phpstan": "^0.10",
+        "phpstan/phpstan-phpunit": "^0.10",
         "phpunit/phpunit": "^7.3",
         "symfony/finder": "^4.1"
     },

phpstan.neon.dist

@@ -0,0 +1,11 @@
+parameters:
+    autoload_files:
+        - vendor/squizlabs/php_codesniffer/autoload.php
+    level: max
+    paths:
+        - src
+        - tests
+
+includes:
+    - vendor/phpstan/phpstan-phpunit/extension.neon
+    - vendor/phpstan/phpstan-phpunit/rules.neon

tests/RulesetTests.php

@@ -59,7 +59,7 @@ public function it_finds_and_fixes_violations(
         sort($actual);
         sort($messages);
 
-        $this->assertSame($messages, $actual, $description);
+        $this->assertSame($messages, $actual, $description ?? '');
         if ($fixedEncoding) {
             $this->assertSame($fixedEncoding, mb_detect_encoding($file->fixer->getContents(), 'UTF-8', true));
         }