Statements must not be empty, except catch blocks (#34)

* Statements must not be empty, except catch blocks

* Update test

Author: thewilkybarkid

src/Libero/ruleset.xml

@@ -13,6 +13,9 @@
     </rule>
 
     <rule ref="Generic.Arrays.DisallowLongArraySyntax"/>
+    <rule ref="Generic.CodeAnalysis.EmptyStatement">
+        <exclude name="Generic.CodeAnalysis.EmptyStatement.DetectedCatch"/>
+    </rule>
     <rule ref="Generic.Commenting.Fixme"/>
     <rule ref="Generic.Commenting.Todo"/>
     <rule ref="Generic.Files.InlineHTML"/>

tests/cases/php/empty-statement

@@ -0,0 +1,28 @@
+---DESCRIPTION---
+Statements must not be empty, except catch blocks
+---CONTENTS---
+<?php
+
+declare(strict_types=1);
+
+if ($foo) {
+    // Bar
+} elseif ($baz) {
+    // Qux
+} else {
+}
+
+try {
+} catch (Exception $e) {
+} catch (Throwable $e) {
+    // Corge
+} finally {
+}
+
+---MESSAGES---
+5:1 Generic.CodeAnalysis.EmptyStatement.DetectedIf
+7:3 Generic.CodeAnalysis.EmptyStatement.DetectedElseif
+9:3 Generic.CodeAnalysis.EmptyStatement.DetectedElse
+12:1 Generic.CodeAnalysis.EmptyStatement.DetectedTry
+16:3 Generic.CodeAnalysis.EmptyStatement.DetectedFinally
+---

tests/cases/php/short-list

@@ -8,6 +8,7 @@ declare(strict_types=1);
 list($foo, $bar) = [$baz, $qux];
 
 foreach ($quux as list('quuz' => $corge, 'grault' => $plugh)) {
+    break;
 }
 
 ---FIXED---
@@ -18,6 +19,7 @@ declare(strict_types=1);
 [$foo, $bar] = [$baz, $qux];
 
 foreach ($quux as ['quuz' => $corge, 'grault' => $plugh]) {
+    break;
 }
 
 ---

tests/cases/php/todo

@@ -6,14 +6,16 @@ TODO comments must not be used
 declare(strict_types=1);
 
 if ($foo) {
-    // TODO add code
+    $bar = 'baz';
+    // TODO add more code
 }
 
+// FIXME please
 if ((1 + 1) === 3) {
-    // FIXME please
+    $qux = 'quuz';
 }
 
 ---MESSAGES---
-6:5 Generic.Commenting.Todo.TaskFound
-10:5 Generic.Commenting.Fixme.TaskFound
+7:5 Generic.Commenting.Todo.TaskFound
+10:1 Generic.Commenting.Fixme.TaskFound
 ---