Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fill parmeter in translate has no effect #175

Closed
tfriedel opened this issue Feb 26, 2022 · 6 comments
Closed

fill parmeter in translate has no effect #175

tfriedel opened this issue Feb 26, 2022 · 6 comments
Labels
bug Something isn't working fixed_in_next_release

Comments

@tfriedel
Copy link

When using the translate operation, the empty part of the result image should be filled with the tuple provided with the "fill" argument. It's currently not being used and thus the background will always consist of (0,0,0).

@GuillaumeLeclerc
Copy link
Collaborator

Hello @tfriedel, Which transform are you referring to ? I don't think FFCV comes with a translate transform does it?

@tfriedel
Copy link
Author

tfriedel commented Mar 3, 2022

@mujjingun
Copy link

When using the translate operation, the empty part of the result image should be filled with the tuple provided with the "fill" argument. It's currently not being used and thus the background will always consist of (0,0,0).

It's actually worse than that, it's uninitialized and once in a while it contains a random value other than 0.0!

@GuillaumeLeclerc GuillaumeLeclerc added bug Something isn't working looking_for_contributor labels Mar 3, 2022
@GuillaumeLeclerc
Copy link
Collaborator

I didn't know we had that augmentation. Sorry about that, I'll try to fix that soon, but if someone wants to go ahead and make a PR it should be pretty straightforward

@andrewilyas
Copy link
Contributor

This should be fixed in #184 !

@andrewilyas
Copy link
Contributor

Now fixed on PyPI!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed_in_next_release
Projects
None yet
Development

No branches or pull requests

4 participants