Fold TagCollectionExtensions.cs into TagCollection.cs

Author: nulltoken

LibGit2Sharp/LibGit2Sharp.csproj

@@ -252,7 +252,6 @@
     <Compile Include="SmartSubtransportStream.cs" />
     <Compile Include="Core\GitSmartSubtransport.cs" />
     <Compile Include="Core\GitSmartSubtransportStream.cs" />
-    <Compile Include="TagCollectionExtensions.cs" />
     <Compile Include="Core\FilePath.cs" />
     <Compile Include="Core\FilePathExtensions.cs" />
     <Compile Include="Core\FilePathMarshaler.cs" />

LibGit2Sharp/TagCollection.cs

@@ -69,6 +69,60 @@ IEnumerator IEnumerable.GetEnumerator()
 
         #endregion
 
+        /// <summary>
+        /// Creates an annotated tag with the specified name.
+        /// </summary>
+        /// <param name="name">The name.</param>
+        /// <param name="objectish">Revparse spec for the target object.</param>
+        /// <param name="tagger">The tagger.</param>
+        /// <param name="message">The message.</param>
+        public virtual Tag Add(string name, string objectish, Signature tagger, string message)
+        {
+            return Add(name, objectish, tagger, message, false);
+        }
+
+        /// <summary>
+        /// Creates an annotated tag with the specified name.
+        /// </summary>
+        /// <param name="name">The name.</param>
+        /// <param name="objectish">Revparse spec for the target object.</param>
+        /// <param name="tagger">The tagger.</param>
+        /// <param name="message">The message.</param>
+        /// <param name="allowOverwrite">True to allow silent overwriting a potentially existing tag, false otherwise.</param>
+        public virtual Tag Add(string name, string objectish, Signature tagger, string message, bool allowOverwrite)
+        {
+            Ensure.ArgumentNotNullOrEmptyString(objectish, "target");
+
+            GitObject objectToTag = repo.Lookup(objectish, GitObjectType.Any, LookUpOptions.ThrowWhenNoGitObjectHasBeenFound);
+
+            return Add(name, objectToTag, tagger, message, allowOverwrite);
+        }
+
+        /// <summary>
+        /// Creates a lightweight tag with the specified name.
+        /// </summary>
+        /// <param name="name">The name.</param>
+        /// <param name="objectish">Revparse spec for the target object.</param>
+        public virtual Tag Add(string name, string objectish)
+        {
+            return Add(name, objectish, false);
+        }
+
+        /// <summary>
+        /// Creates a lightweight tag with the specified name.
+        /// </summary>
+        /// <param name="name">The name.</param>
+        /// <param name="objectish">Revparse spec for the target object.</param>
+        /// <param name="allowOverwrite">True to allow silent overwriting a potentially existing tag, false otherwise.</param>
+        public virtual Tag Add( string name, string objectish, bool allowOverwrite)
+        {
+            Ensure.ArgumentNotNullOrEmptyString(objectish, "objectish");
+
+            GitObject objectToTag = repo.Lookup(objectish, GitObjectType.Any, LookUpOptions.ThrowWhenNoGitObjectHasBeenFound);
+
+            return Add(name, objectToTag, allowOverwrite);
+        }
+
         /// <summary>
         /// Creates an annotated tag with the specified name.
         /// </summary>
@@ -133,6 +187,17 @@ public virtual Tag Add(string name, GitObject target, bool allowOverwrite)
             return this[name];
         }
 
+        /// <summary>
+        /// Deletes the tag with the specified name.
+        /// </summary>
+        /// <param name="name">The short or canonical name of the tag to delete.</param>
+        public virtual void Remove(string name)
+        {
+            Ensure.ArgumentNotNullOrEmptyString(name, "name");
+
+            Proxy.git_tag_delete(repo.Handle, UnCanonicalizeName(name));
+        }
+
         /// <summary>
         /// Deletes the tag with the specified name.
         /// </summary>
@@ -141,7 +206,7 @@ public virtual void Remove(Tag tag)
         {
             Ensure.ArgumentNotNull(tag, "tag");
 
-            this.Remove(tag.CanonicalName);
+            Remove(tag.CanonicalName);
         }
 
         private static string NormalizeToCanonicalName(string name)
@@ -156,7 +221,7 @@ private static string NormalizeToCanonicalName(string name)
             return string.Concat(Reference.TagPrefix, name);
         }
 
-        internal static string UnCanonicalizeName(string name)
+        private static string UnCanonicalizeName(string name)
         {
             Ensure.ArgumentNotNullOrEmptyString(name, "name");