Conversation
Member
Author
|
/cc @shiftkey |
Member
There was a problem hiding this comment.
How about moving this in MockedRepositoryFixture.cs (and maybe give the test suite a more generic name (eg. MockingFixture, ...))?
Member
Author
Member
|
Love it! Squashing time? |
Member
Author
|
Squashed |
Member
|
...and merged! 🎱 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simpler change that should address concerns addressed by #569. Specifically:
BuildSignature()is handy enough to publicize. Added asvirtualonConfigurationinstead of as an extension method to replace two fake setups with one.ConfigurationEntry<T>can besealedsince its ctor parameters map directly to its properties.GetEnumerator()is now avirtualmember instead of an explicit interface implementation. Some mocking frameworks can handle it (e.g. Moq:mockConfig.As<IEnumerable<ConfigurationEntry<string>>>().Setup(...)) but it's ugly...