-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organising option flags #35
Comments
Its nice, but i think WebSockets transport could not work without TCP transport and QUIC transport could not work without UDP transport. |
This is nice for testing. We should also have a flag that specifies the listen addresses, so that we can only listen on QUIC for example but still be able to dial tcp. |
It's pretty nice to me. If there are too many combinations of the flags in a namespace, does it make sense to have something like |
I like this approach, I think it would be great to get spec'd out. When implementing the js daemon I referenced the cli parser of the go implementation, but it would be great to see that externalized as a spec. This will also ensure our interop testing is a lot easier if we can just leverage the same flags consistently.
I'd like to see us leverage something like #63 to overcome the large number of flags problem. I think it's a nice approach for running more customized nodes. |
As users demand more functionalities (e.g. #34), we're likely to see a proliferation of option flags for the daemon binary. While the daemon is marked as an experimental project, we should attempt to bring in structure to our option flags. Let's agree on an approach and lock it in.
Proposal:
go test
uses no casing or separators, andipfs
uses hyphens. My proposal is to use hyphens.For transports, this can look as follows:
So if I wanted to enable ONLY QUIC, I'd do the following:
WDYT? CC @vyzo @bigs @jrhea @cheatfate @mhchia
The text was updated successfully, but these errors were encountered: