Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming & modularization #89

Closed
daviddias opened this issue Jul 16, 2018 · 4 comments
Closed

Naming & modularization #89

daviddias opened this issue Jul 16, 2018 · 4 comments

Comments

@daviddias
Copy link
Member

To avoid future confusion such as -- #67 (comment) --. I want to propose that we adopt the following:

  • go-pubsub - The pubsub API and the thing that knows how to take multiple pubsub implementation
  • go-floodsub - The floodsub implementation
  • go-gossipsub - The gossipsub implementation

This will make it very clear that libp2p/IPFS support multiple pubsub implementations and that we encourage everyone to try new ones.

@Stebalien
Copy link
Member

My current plan is to:

  1. Remove the current go-libp2p-pubsub.
  2. Rename this package to go-libp2p-pubsub.
  3. Eventually extract the floodsub/gossiphub from it.

The implementations are currently bundled with this repo as we'll probably need to refactor things quite a bit to get the interfaces right.

@hsanjuan
Copy link
Contributor

We can proceed with this at this point?

@vyzo
Copy link
Collaborator

vyzo commented Oct 17, 2018

We can probably proceed with steb's 1&2.

@daviddias
Copy link
Member Author

This is now solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants