Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

Remove deprecated Warning/Warningf log calls #213

Closed
travisperson opened this issue May 5, 2020 · 1 comment
Closed

Remove deprecated Warning/Warningf log calls #213

travisperson opened this issue May 5, 2020 · 1 comment

Comments

@travisperson
Copy link

Both Warning and Warningf are deprecated in go-log@v1.0.4 and removed in the newer v2. The current use of these deprecated methods impacts the ability to get proper caller information. Logs produced with these methods result in one of two callers inside of the go-log package.

Eg: go-log@v1.0.4/log.go:180, or go-log@v1.0.4/log.go:175.

This makes it more cumbersome to filter through logs when using tools like Kibana where filtering in/out a log line by caller is easier than trying to filter in/out a string of a message. It also makes it hard for anyone not familiar with the libp2p code base to understand where a log is coming from. For warning logs particular knowing the actual caller is important.

@marten-seemann
Copy link
Contributor

We updated to go-log v2 in #294.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants