Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

identify: flaky TestIdentifyDeltaOnProtocolChange (again) #1575

Closed
marten-seemann opened this issue May 28, 2022 · 0 comments · Fixed by #1582
Closed

identify: flaky TestIdentifyDeltaOnProtocolChange (again) #1575

marten-seemann opened this issue May 28, 2022 · 0 comments · Fixed by #1582
Assignees
@MarcoPolo
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@marten-seemann
Copy link
Contributor

Looks like waiting for the event (#1568) didn't solve the flakiness in this test.

  === RUN   TestIdentifyDeltaOnProtocolChange
      id_test.go:399: Missing id event
  --- FAIL: TestIdentifyDeltaOnProtocolChange (5.01s)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarcoPolo MarcoPolo

Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

identify: fix flaky TestIdentifyDeltaOnProtocolChange (again) libp2p/go-libp2p
2 participants
@MarcoPolo @marten-seemann