Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security protocol ordering preference broken #1906

Closed
2 tasks done
Tracked by #1766
marten-seemann opened this issue Nov 20, 2022 · 3 comments · Fixed by #1912
Closed
2 tasks done
Tracked by #1766

security protocol ordering preference broken #1906

marten-seemann opened this issue Nov 20, 2022 · 3 comments · Fixed by #1912
Assignees
Labels
kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP

Comments

@marten-seemann
Copy link
Contributor

marten-seemann commented Nov 20, 2022

Since fx groups don't provide ordering (see https://pkg.go.dev/go.uber.org/fx#hdr-Value_Groups), we end up not adhering to the ordering of the configured security protocols.

We need to:

  • fix this bug
  • add an integration test

This is a blocker for the v0.24.0 release.

@marten-seemann marten-seemann added kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP labels Nov 20, 2022
@marten-seemann marten-seemann self-assigned this Nov 20, 2022
@vyzo
Copy link
Contributor

vyzo commented Nov 20, 2022

fx.... lol.

@marten-seemann
Copy link
Contributor Author

@vyzo Enjoy your told-you-so moment.

The fact that we didn't have any tests for security protocol selection is the real culprit here, as I see it.

@vyzo
Copy link
Contributor

vyzo commented Nov 20, 2022

it was a small triumph :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants