-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
security protocol ordering preference broken #1906
Comments
marten-seemann
added
kind/bug
A bug in existing code (including security flaws)
P0
Critical: Tackled by core team ASAP
labels
Nov 20, 2022
This was referenced Nov 20, 2022
Closed
fx.... lol. |
@vyzo Enjoy your told-you-so moment. The fact that we didn't have any tests for security protocol selection is the real culprit here, as I see it. |
it was a small triumph :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since fx groups don't provide ordering (see https://pkg.go.dev/go.uber.org/fx#hdr-Value_Groups), we end up not adhering to the ordering of the configured security protocols.
We need to:
This is a blocker for the v0.24.0 release.
The text was updated successfully, but these errors were encountered: