-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connectedness events are not submitted by mocknet #2267
Comments
|
I am sure Lotus depends on it, and they will likely want to update to v0.27. I can submit a patch but in weeks from now. |
Why is it unmaintained? |
Thanks for the PR, I'll review :) What do you think about a in-memory transport? It would let us run all the same code as normal, but use Go channels/runtime to do the actual network part of it. It'll probably behave more realistically and use less code than mocknet. For prior art, rust-libp2p has an in-memory transport. |
After #1574, the
Network
is now responsible for emitting such events. However, onlySwarm
was updated to emit them, and the only second implementation,mocknet
was not. There are projects in the ecosystem that usesmockent
and for whom updating to v0.27 will break tests because of this.Additionally, the tests that depend on
swarm/testing
will break as well due to the reason @vyzo mentioned in here. The user now has two instantiate the EventBus themselves and pass two both the host constructor and theGenSwarm
, but if I understand correctly this is part of a larger issue #1993.The text was updated successfully, but these errors were encountered: