Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface refactors once auto-relay PR merged #472

Closed
ghost opened this issue Nov 5, 2018 · 1 comment
Closed

Interface refactors once auto-relay PR merged #472

ghost opened this issue Nov 5, 2018 · 1 comment
Assignees
Labels
P1 High: Likely tackled by core team if no one steps up topic/filecoin Topic filecoin

Comments

@ghost
Copy link

ghost commented Nov 5, 2018

Following some synchronous discussion in the libp2p bi-weekly meeting today, resolved:

  • autorelay #454 is good to merge 🍾
  • Ideally, interfaces that may change should be marked as unstable in that PR
  • @vyzo, @Stebalien and @bigs should quickly figure out how to refactor interfaces before users start relying on them. Two main areas identified by @Stebalien:
    1. push identify method
    2. revise the identify service to push new addresses

I'll let you all discuss these matters here. Marking as high priority so that it does not get forgotten. 😀

@ghost ghost added P1 High: Likely tackled by core team if no one steps up topic/filecoin Topic filecoin labels Nov 5, 2018
@ghost ghost assigned vyzo, bigs and Stebalien Nov 5, 2018
@marten-seemann
Copy link
Contributor

I'm not sure I understand what exactly should be refactored, but

... should quickly figure out how to refactor interfaces before users start relying on them

I suppose that ship has sailed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High: Likely tackled by core team if no one steps up topic/filecoin Topic filecoin
Projects
None yet
Development

No branches or pull requests

4 participants