Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If we don't observe an address for 10 minutes, we stop announcing it. #716

Closed
Stebalien opened this issue Sep 4, 2019 · 3 comments
Closed

If we don't observe an address for 10 minutes, we stop announcing it. #716

Stebalien opened this issue Sep 4, 2019 · 3 comments
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@Stebalien
Copy link
Member

We really need to be smarter about this.

  1. Identify (or some other protocol) should send negative observations (I tried dialing X and failed).
  2. We may want to consider keeping observed addrs as long as the connection that made the observation is still open. Unfortunately, this is a bit annoying to track.
@Stebalien Stebalien added the kind/bug A bug in existing code (including security flaws) label Sep 4, 2019
@MichaelMure
Copy link

I very much might be incorrect here, but I believe this would also avoid propagating the localhost or private IPs in the network and have everyone try to dial them.

@Stebalien
Copy link
Member Author

See #436.

@marten-seemann
Copy link
Contributor

This would have be solved by AutoNAT v2 (libp2p/specs#503).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MichaelMure @Stebalien @marten-seemann