Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

disable most of the metrics collection on Windows #91

Closed
marten-seemann opened this issue Aug 18, 2021 · 0 comments · Fixed by #93
Closed

disable most of the metrics collection on Windows #91

marten-seemann opened this issue Aug 18, 2021 · 0 comments · Fixed by #93
Labels
effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers kind/enhancement A net-new feature or improvement to an existing feature

Comments

@marten-seemann
Copy link
Contributor

We won't get anything from the kernel anyway: https://github.com/mikioh/tcp/blob/803a9b46060c1d8b9ee03ff0386b87c179f50227/sys_windows.go#L71-L73

We can therefore only trace connection durations.
@marten-seemann marten-seemann added kind/enhancement A net-new feature or improvement to an existing feature exp/beginner Can be confidently tackled by newcomers effort/hours Estimated to take one or several hours labels Aug 18, 2021
@marten-seemann marten-seemann mentioned this issue Aug 31, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

disable metrics collection on Windows libp2p/go-tcp-transport
1 participant
@marten-seemann