Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

chore: add discv5 peer discovery module #44

Merged
merged 1 commit into from
Apr 11, 2020

Conversation

wemeetagain
Copy link
Member

No description provided.

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@vasco-santos vasco-santos merged commit dba3b99 into libp2p:master Apr 11, 2020
@vasco-santos
Copy link
Member

@wemeetagain

FYI in libp2p@0.28 we will change the peer-discovery module. It will probably change as #41 but I will let you know. By that time, it will be useful to add the compliance tests, since they are updated there.

I will aldo add this module to the js-libp2p packages table

@vasco-santos
Copy link
Member

@wemeetagain can we have discv5 with a leadMaintainer in the package.json?

For libp2p/js-libp2p#606, we use a tool which gathers this data from the repos to add the leadMaintainer in the js-libp2p Readme package table.

@wemeetagain
Copy link
Member Author

@vasco-santos 👍 We're looking forward to 0.28, deprecated PeerInfo, new PeerStore, etc
Let us know when would be appropriate to revisit upgrading.

We just updated discv5 package.json with the leadMaintainer.

@wemeetagain wemeetagain deleted the patch-1 branch April 11, 2020 19:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants