This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
fix: use node crypto for ed25519 signing and verification #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In node, use the node crypto module for ed25519 signing/verification now that it's in all LTS releases. Browsers still use the pure-js `@noble/ed25519` implementation. Before: ``` @libp2p/crypto x 484 ops/sec ±0.34% (90 runs sampled) ``` After: ``` @libp2p/crypto x 4,706 ops/sec ±0.81% (84 runs sampled) ```
Co-authored-by: Marin Petrunić <mpetrunic@users.noreply.github.com>
mpetrunic
reviewed
Dec 1, 2022
mpetrunic
approved these changes
Dec 1, 2022
|
🎉 |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 1, 2022
## [1.0.9](v1.0.8...v1.0.9) (2022-12-01) ### Bug Fixes * use node crypto for ed25519 signing and verification ([#289](#289)) ([1c623e7](1c623e7))
|
🎉 This PR is included in version 1.0.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In node, use the node crypto module for ed25519 signing/verification now that it's in all LTS releases.
Browsers still use the pure-js
@noble/ed25519implementation.Running the ed25519 benchmark:
Before:
After: