This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
feat: simpler peer id #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors `PeerId`s with the aim of making them easier to use in places like API clients where you generally don't do any cryptographic operations. Splits the existing `peer-id` functionality into `libp2p-peer-id` for everyday activities like turning strings/byte arrays into `PeerId`s, and `libp2p-peer-id-factory` for generating new keypairs and creating `PeerId`s from them, also creating them from protobuf bytes, json objects, and other esoteric formats. Depending on use of those formats we may move the methods into `libp2p-peer-id` in future but it's a reasonable start.
|
🎉 This PR is included in version @libp2p/interfaces-v1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @libp2p/peer-id-v1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @libp2p/topology-v1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @libp2p/peer-id-factory-v1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @libp2p/connection-v1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @libp2p/pubsub-v1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
PeerIds with the aim of making them easier to use in places like API clients where you generally don't do any cryptographic operations.Splits the existing
peer-idfunctionality intolibp2p-peer-idfor everyday activities like turning strings/byte arrays intoPeerIds, andlibp2p-peer-id-factoryfor generating new keypairs and creatingPeerIds from them, also creating them from protobuf bytes, json objects, and other esoteric formats.Depending on use of those formats we may move the methods into
libp2p-peer-idin future but it's a reasonable start.Tries to remove some of the duplication in parsing
PeerIDs out of strings, and also tries to not create lots ofCIDobjects when trying to parsePeerIDs out of byte arrays.There's a lot of noise in this PR, maybe the place to start is: