Query - run is overwritten

[kumavis]

Query has a method called run. Query also assigns to this.run which would shadow the method. Is this a mistake or intentional? If its intentional its surprising and should be heavily commented.

js-libp2p-kad-dht/src/query/index.js

Lines 56 to 67 in ddf80fe

	run (peers, callback) {
	if (!this.dht._queryManager.running) {
	this._log.error('Attempt to run query after shutdown')
	return callback(null, { finalSet: new Set(), paths: [] })
	}
	if (peers.length === 0) {
	this._log.error('Running query with no peers')
	return callback(null, { finalSet: new Set(), paths: [] })
	}
	this.run = new Run(this)

[kumavis]

query.run is called at least here

[kumavis]

cant wait for the Awesome Typescript Endeavour 😉

[kumavis]

related #113

[vasco-santos]

This should be fixed by #116