Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

feat: find providers and closest peers return async iterable #157

Merged
merged 1 commit into from
Nov 30, 2019

Conversation

vasco-santos
Copy link
Member

@vasco-santos vasco-santos commented Nov 29, 2019

This PR aims to get consistency with libp2p-delegated-*-routing, as well as with libp2p-daemon

BREAKING CHANGE: API for find providers and closest peers return async iterable instead of an array of PeerInfo

Closes #151

BREAKING CHANGE: API for find providers and closest peers return async iterable instead of an array of PeerInfo
@vasco-santos vasco-santos force-pushed the feat/find-providers-return-async-iterable branch from 09e15ba to 92a6766 Compare November 29, 2019 19:36
@vasco-santos vasco-santos changed the title feat: find providers return async iterable feat: find providers and closest peers return async iterable Nov 29, 2019
@vasco-santos vasco-santos marked this pull request as ready for review November 29, 2019 19:42
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this will also make it easier to internally refactor the closestPeersQuery to actually stream results back.

@vasco-santos vasco-santos merged commit f0e6800 into master Nov 30, 2019
@vasco-santos vasco-santos deleted the feat/find-providers-return-async-iterable branch November 30, 2019 10:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make getClosestPeers an async generator
2 participants