Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

Use only pull-streams, reduce memory usage and improve perf by a **lot** #73

Closed
daviddias opened this issue Feb 19, 2018 · 4 comments
Closed

Use only pull-streams, reduce memory usage and improve perf by a **lot** #73

daviddias opened this issue Feb 19, 2018 · 4 comments
Assignees
@dryajov
Labels
exp/wizard Extensive knowledge (implications, ramifications) required help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked

Comments

@daviddias
Copy link
Member

long story short: libp2p-mplex has been around for a while, longer than our migration for pull-streams. Things work now but we know that using Readable Streams in the browser is a huge memory inefficiency and might cause bugs that we are not even aware right now.

Now that #68 #72 happened. We should upgrade the whole module to drop Readable Streams entirely.
@daviddias daviddias added help wanted Seeking public contribution on this issue exp/wizard Extensive knowledge (implications, ramifications) required P1 High: Likely tackled by core team if no one steps up labels Feb 19, 2018
@daviddias daviddias mentioned this issue Feb 19, 2018
Closed
13 tasks
@daviddias daviddias added the status/ready Ready to be worked label Feb 19, 2018
@daviddias
Copy link
Member Author

This should be considerably simpler now that there is https://github.com/libp2p/mplex

This would remove the Readable Stream shims from libp2p as a whole!

@daviddias daviddias changed the title Use only pull-streams Use only pull-streams, reduce memory usage and improve perf by a **lot** Mar 19, 2018
@dryajov dryajov self-assigned this Mar 23, 2018
@dryajov dryajov added status/in-progress In progress and removed status/ready Ready to be worked labels Mar 23, 2018
@dryajov dryajov mentioned this issue Mar 26, 2018
Merged
@daviddias daviddias mentioned this issue Mar 27, 2018
Closed
15 tasks
@daviddias
Copy link
Member Author

@dryajov can you share an update here on the perf boost and mem improvements?

@dryajov
Copy link
Member

dryajov commented May 12, 2018

Per related info is here - libp2p/pull-mplex#4.

@vasco-santos vasco-santos mentioned this issue Jun 28, 2018
Merged
@daviddias daviddias added status/ready Ready to be worked and removed status/in-progress In progress labels Nov 14, 2018
@vasco-santos
Copy link
Member

Not relevant anymore after the async refactor of this module

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dryajov dryajov

Labels
exp/wizard Extensive knowledge (implications, ramifications) required help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dryajov @daviddias @vasco-santos