This repository has been archived by the owner on Aug 23, 2019. It is now read-only.
stats - stat - prevent 0ms timeDiff breaking movingAverage #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
kumavis
force-pushed
the
stats-infinity-hz
branch
from
8c922ea
to
b80766e
Compare
jacobheun
approved these changes
Apr 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/libp2p/js-libp2p-switch/issues/335
This is a work around, and will still cause an inaccurate movingAverage when pushing in data immediately after creation, but movingAverage will "heal" over time
a more correct solution might be not pushing in the initial zero and first waiting for 2 samples