-
Notifications
You must be signed in to change notification settings - Fork 40
Conversation
These metrics are very useful but they should be added to the built in libp2p metrics object instead of being their own thing |
Why? |
bc0bf79
to
fffffe4
Compare
So there's a central point to collect metrics from for viewing, rather than having to go and ask every component, and so each component submits metrics in the same format following the same interface. |
How can I do .inc with the built in libp2p metrics object? |
9388ea5
to
183f741
Compare
Updated PR to use a "metrics generator" so that consumer only needs to pass something that can create Gauge instances. This follows similar encapsulation principles as built in libp2p metrics object but with no performance penalty. |
183f741
to
12b7927
Compare
Uses new metrics interface from libp2p/js-libp2p-interfaces#310 to report useful connection metrics. Similar to #217 but it adds the listening host/port to the metrics name to allow multiple TCP listeners to report metrics separately.
Uses new metrics interface from libp2p/js-libp2p-interfaces#310 to report useful connection metrics. Similar to #217 but it adds the listening host/port to the metrics name to allow multiple TCP listeners to report metrics separately. BREAKING CHANGE: requires metrics interface v4
depends on libp2p/js-libp2p#1458 |
#223 adds the same metrics as this PR: tcp server status, active connections, listener errors, and socket events I think we'll want to add a Gauge interface to interface-metrics here and convert some counters to gauges afterwards. |
|
Adds metrics for Prometheus-like collecting engine: