Tests are failing and Code Coverage is kind of low

[daviddias]

@mkg20001 wanna take a look into that?

[mkg20001]

Does #43 improve it?

[mkg20001]

Note that the tests are in libp2p-websocket-star (rewrite-v2 branch) and not here in the server otherwise they would be duplicated. Got any ideas of how to resolve that?

[daviddias]

We strive to have Master always green on CI. #43 might improve it but the reality is that it is blocked until libp2p/js-libp2p#159.

Can you improve the master branch as is to make sure the tests there are 100% passing?

[mkg20001]

Actually #43 isn't blocked so much by that because the .__setSwarm hack works pretty well and considering this module is actually a giant hack (because p2p-circuit is already a thing, maybe we should remove relay here and rename this to webMDNS? libp2p/js-libp2p-webrtc-star#128 (comment)) so I don't know why we shouldn't use that hack to fix the hack...

[mkg20001]

Btw, to fix this module I need multiformats/js-mafmt#21 merged and released first

[daviddias]

mafmt v4.0.0 published.

[mkg20001]

Tests should be now (that really depends on whether or not travis is in good mood today) fixed

[daviddias]

Thank you :)

For the future, please avoid pushing directly into master.

[daviddias]

Coverage is still kind of low (69%)

[mkg20001]

Didn't we want to get rid of ws-star anyway? Does this even matter then?

[jacobheun]

Tests in master are stable, https://ci.ipfs.team/blue/organizations/jenkins/libp2p%2Fjs-libp2p-websocket-star/activity?branch=master, and coverage is >80%.

Closing this.