Skip to content

Commit e6a41f7

Browse files
authoredJul 31, 2023
fix: update max message size SDP attribute (#1909)
Updates max message size to comply with spec. Closes #1908
1 parent 1f7e18b commit e6a41f7

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed
 

‎packages/transport-webrtc/src/private-to-public/sdp.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ a=ice-ufrag:${ufrag}
133133
a=ice-pwd:${ufrag}
134134
a=fingerprint:${CERTFP}
135135
a=sctp-port:5000
136-
a=max-message-size:100000
136+
a=max-message-size:16384
137137
a=candidate:1467250027 1 UDP 1467250027 ${host} ${port} typ host\r\n`
138138
}
139139

‎packages/transport-webrtc/test/sdp.spec.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ a=ice-ufrag:MyUserFragment
1717
a=ice-pwd:MyUserFragment
1818
a=fingerprint:SHA-256 72:68:47:CD:48:B0:5E:C5:60:4D:15:9C:BF:40:1D:6F:00:A1:23:EC:90:17:0E:2C:D1:B3:8F:D2:9D:37:E5:B1
1919
a=sctp-port:5000
20-
a=max-message-size:100000
20+
a=max-message-size:16384
2121
a=candidate:1467250027 1 UDP 1467250027 0.0.0.0 56093 typ host`
2222

2323
describe('SDP', () => {
@@ -73,7 +73,7 @@ a=ice-ufrag:someotheruserfragmentstring
7373
a=ice-pwd:someotheruserfragmentstring
7474
a=fingerprint:SHA-256 72:68:47:CD:48:B0:5E:C5:60:4D:15:9C:BF:40:1D:6F:00:A1:23:EC:90:17:0E:2C:D1:B3:8F:D2:9D:37:E5:B1
7575
a=sctp-port:5000
76-
a=max-message-size:100000
76+
a=max-message-size:16384
7777
a=candidate:1467250027 1 UDP 1467250027 0.0.0.0 56093 typ host`
7878

7979
expect(result.sdp).to.equal(expected)

0 commit comments

Comments
 (0)