Fix type definition for v0.35.6 #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tuyen Nguyen <vutuyen2636@gmail.com>
| @@ -110,7 +112,7 @@ const { updateSelfPeerRecord } = require('./record/utils') | |||
| * @property {KeychainOptions & import('./keychain/index').KeychainOptions} [keychain] | |||
| * @property {MetricsOptions & import('./metrics').MetricsOptions} [metrics] | |||
| * @property {import('./peer-routing').PeerRoutingOptions} [peerRouting] | |||
| * @property {PeerStoreOptions & import('./peer-store/persistent').PersistentPeerStoreOptions} [peerStore] | |||
| * @property {PeerStoreOptions & PersistentPeerStoreOptions} [peerStore] | |||
There was a problem hiding this comment.
Why can't we use the types defined in
instead of duplicating them?There was a problem hiding this comment.
I suppose that's an issue with pbjs when we use that along with const PersistentPeerStore = require('./peer-store/persistent') at the beginning, it'd generate PersistentPeerStore.PersistentPeerStoreOptions and cause the error
@chainsafe/lodestar: ../../node_modules/libp2p/dist/src/index.d.ts:413:37 - error TS2503: Cannot find namespace 'PersistentPeerStore'.
@chainsafe/lodestar: 413 peerStore?: (PeerStoreOptions & PersistentPeerStore.PersistentPeerStoreOptions) | undefined;
this does not look fancy but I can't find other ways to get through that, any suggestions @vasco-santos ? Upgrading to the latest version of pbjs did not help
There was a problem hiding this comment.
ok, let's keep it. It is just a property
vasco-santos
approved these changes
Dec 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Closes #1073