Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circuit relay - reconnect to peers we have reservations on #1955

Closed
achingbrain opened this issue Aug 10, 2023 · 3 comments
Closed

Circuit relay - reconnect to peers we have reservations on #1955

achingbrain opened this issue Aug 10, 2023 · 3 comments
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@achingbrain
Copy link
Member

When we have a reservation on a relay, and we lose connectivity to that relay, we should make an effort to reconnect to the same relay before searching for other relays to make a reservation on.

This is because making a new reservation will change our multiaddrs which impacts things like DHT provider records which will now be out of date just because our WiFi was a bit flaky for a time or we closed our laptop lid.

@whizzzkid
Copy link

Thoughts, based on the hypothesis presented:

  • What defines a good relay?
  • Would a LRU type data structure help get better relays historically?
  • Furthermore a weighted data-structure (possibly a learning/AI model) which scores the relays based on their reliability/data-structures/latency etc, (prolly overkill) but would be better?

@maschad
Copy link
Member

maschad commented Sep 7, 2023

I think this relates to #1953 - i.e. as a general rule, if we've successfully dialled the peer recently, but we are no longer connected to them, we should prioritize dialling those peers and conversely if we have dialled a peer but failed recently, then those should be de-prioritized.

@maschad maschad moved this to 🥞Weekly Candidates/Discuss🎙 in js-libp2p Sep 11, 2023
@maschad maschad moved this from 🥞Weekly Candidates/Discuss🎙 to 🏃‍♀️In Progress in js-libp2p Sep 12, 2023
@maschad maschad added kind/enhancement A net-new feature or improvement to an existing feature and removed need/triage Needs initial labeling and prioritization labels Sep 12, 2023
@maschad
Copy link
Member

maschad commented Oct 2, 2023

Closed by #2031

@maschad maschad closed this as completed Oct 2, 2023
@github-project-automation github-project-automation bot moved this from 🏃‍♀️In Progress to 🎉Done in js-libp2p Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants