-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@libp2p/protocol-perf): ensure only client calls measure performance #1960
fix(@libp2p/protocol-perf): ensure only client calls measure performance #1960
Conversation
Please can you check the state of the build before merging PRs. The previous commit merged would have performed a release. One of the interop tests timed out which means the release didn't happen. Now this commit is the head of master so release-please will not (may not?) perform the release since it's no longer the tip of the tree. In general please do not merge to master when master is red. |
My apologies, noted. Perhaps another way to articulate it is we should ensure our releases are successful before merging to master. |
According to the spec perf is a client-driven set of benchmarks., therefore the server need not call the measurePerfomance method. This PR fixes two things:
measurePerformance
method