-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use logging component everywhere #2228
Conversation
Refactors all components to accept a `ComponentLogger` that lets us prefix log lines with peer ids/arbitrary strings, etc.
Refactors all components to accept a `ComponentLogger` that lets us prefix log lines with peer ids/arbitrary strings, etc.
Refactors all components to accept a `ComponentLogger` that lets us prefix log lines with peer ids/arbitrary strings, etc.
@achingbrain This is actually BREAKING CHANGE!
I used |
@akim-bow the last 0.46.x release was 0.46.21 - I think you may have some mixed dependency versions, you may need to remove your lockfiles and install again. You should get |
@achingbrain
There is no lockfile involved, my case is a clean installation of a libp2p of specific version. In my opinion, if dependency update requires updating dependent package - it should be marked as a BREAKING CHANGE. |
You are quite right, unfortunately we are all human and sometimes we make mistakes. Please ensure you have the latest |
Thanks! |
Refactors all components to accept a
ComponentLogger
that lets us prefix log lines with peer ids/arbitrary strings, etc.Closes #2207
Closes #2105
Change checklist