fix: do not find peer when DHT yields peers without multiaddrs #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go-libp2p recently reduced the length of time it stores multiaddrs for peers in case they go out of date. This means that queries have started finding provdiers/closer peers without multiaddrs as those addreses expire. We switched to running a find peer when these addressless peers are discovered but it is incredibly expensive since a single find peer can result in multiple dials. Instead honor the peer without multiaddrs, a separate PR will be opened to allow doing the find peer at dial time if the user choses to dial the discovered peer.
Merged
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-libp2p recently reduced the length of time it stores multiaddrs for peers in case they go out of date. This means that queries have started finding provdiers/closer peers without multiaddrs as those addreses expire.
We switched to running a find peer when these addressless peers are discovered but it is incredibly expensive since a single find peer can result in multiple dials.
Instead honor the peer without multiaddrs, a separate PR will be opened to allow doing the find peer at dial time if the user choses to dial the discovered peer.
Change checklist