Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add private key to libp2p components #2348

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Conversation

wemeetagain
Copy link
Member

Description

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@wemeetagain wemeetagain requested a review from a team as a code owner January 8, 2024 22:34
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion but otherwise LGTM

Co-authored-by: Alex Potsides <alex@achingbrain.net>
@achingbrain
Copy link
Member

Just needs green CI before merge.

@achingbrain achingbrain merged commit 092861e into main Jan 16, 2024
23 checks passed
@achingbrain achingbrain deleted the feat/add-private-key branch January 16, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants