Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instructions for libp2p in browser example #304

Closed
malisetti opened this issue Jan 3, 2019 · 2 comments · Fixed by #306
Closed

Fix instructions for libp2p in browser example #304

malisetti opened this issue Jan 3, 2019 · 2 comments · Fixed by #306
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now

Comments

@malisetti
Copy link

Name: libp2p-in-the-browser
Version: 0.1.0
Node Version: v11.1.0
NPM Version: 6.4.1
Platform: Linux IMCHLT047 4.15.0-43-generic #46-Ubuntu SMP Thu Dec 6 14:45:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Severity: Medium

Description: when followed the steps from https://github.com/libp2p/js-libp2p/tree/master/examples/libp2p-in-the-browser i get the below error.

Error: $ npm start

libp2p-in-the-browser@0.1.0 start /home/seshachalamm/js-libp2p/examples/libp2p-in-the-browser/1
npm run bundle && npm run serve

libp2p-in-the-browser@0.1.0 bundle /home/seshachalamm/js-libp2p/examples/libp2p-in-the-browser/1
browserify src/index.js > public/bundle.js

Error: Cannot find module 'fsm-event' from '/home/seshachalamm/js-libp2p/src'

Steps to reproduce the error:

Follow the steps from https://github.com/libp2p/js-libp2p/tree/master/examples/libp2p-in-the-browser

@malisetti
Copy link
Author

Doing an npm install in js-libp2p directory solves this.

@jacobheun jacobheun changed the title Error while running libp2p in browser example Fix instructions for libp2p in browser example Jan 3, 2019
@jacobheun
Copy link
Contributor

We should update the instructions to indicate the need to run install in project root.

@jacobheun jacobheun added kind/bug A bug in existing code (including security flaws) help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up status/ready Ready to be worked P3 Low: Not priority right now labels Jan 3, 2019
@ghost ghost removed the status/ready Ready to be worked label Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants