-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discuss: "bundling" terminology is confusing #350
Comments
cc @Mikerah |
I actually think it's great to point to real examples of libp2p node configurations like the ones in IPFS. Can we point to other projects too? |
Alternatively we may want to bring in those examples into libp2p itself as "blueprints" or something. |
@jacobheun gotcha, let's dislodge all this stuff! Should we create a |
I agree that this is a confusing bit of terminology - we should either publish common "bundles" as npm packages, or just get rid of the term entirely and refer to "configuring libp2p" instead as suggested here. |
I actually just got into this very issue a few days ago. I used the word bundle in the same paragraph both in the JS sense and libp2p sense. A suggestion I have would just to refer to them as libp2p modules or libp2p configurations. |
We got away of the |
The term "bundle" in modern Javascript land often implies things like packaging, minification, tree shaking, etc. all of which don't apply in our usage of the term. It evokes Webpack, Parcel, etc. I've received feedback from developers that this is confusing.
Really, what we are trying to recommend is putting libp2p imports and configuration in one file, and exporting it from there. Calling that a "bundle" is unnecessarily complex IMO.
Can we simplify this?
The text was updated successfully, but these errors were encountered: