fix: clean up peer discovery flow #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
reviewed
Dec 3, 2019
| @@ -217,6 +206,16 @@ class PeerStore extends EventEmitter { | |||
|
|
|||
| this.remove(peerInfo.id.toB58String()) | |||
| this.add(peerInfo) | |||
|
|
|||
| // This should be cleaned up in PeerStore v2 | |||
| this.emit('change:multiaddrs', { | |||
There was a problem hiding this comment.
the multiaddrs may not change, right?
jacobheun
added a commit
that referenced
this pull request
Dec 12, 2019
* fix: clean up peer discovery flow * test(fix): let libp2p start after connecting * test(fix): dont auto dial in disco tests
jacobheun
added a commit
that referenced
this pull request
Jan 24, 2020
* fix: clean up peer discovery flow * test(fix): let libp2p start after connecting * test(fix): dont auto dial in disco tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
peerStore.updateno longer replaces existing protocols and multiaddrs, this is inline with PeerBook.peerStore.replace()instead ofpeerStore.update(). As we are talking directly with the target peer, we should consider them the source of truth. With Multiaddr confidence in the future and PeerStore v2, this may may change.peerevents will now be directed to the peerStore directly.peer:discoveryevents are now being Proxied from the PeerStore. This also ensures we won't discover a peer twice.PeerStore.replace()will always triggerchange:multiaddrsandchange:protocolsevents. This is an oversimplification and may not indicate an actual change, but this is probably better reserved for PeerStore v2 work.