feat: discovery modules from transports should be added #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
feat/discovery-modules-from-transports-should-be-enabled
branch
from
78040ca
to
7f216a9
Compare
jacobheun
reviewed
Dec 11, 2019
src/index.js
Outdated
| @@ -448,7 +448,8 @@ class Libp2p extends EventEmitter { | |||
| config = { ...config, ...this._config.peerDiscovery[DiscoveryService.tag] } | |||
| } | |||
|
|
|||
| if (config.enabled) { | |||
| if (config.enabled && | |||
| !this._discovery.filter((service) => service.tag === DiscoveryService.tag).length) { // not already added | |||
There was a problem hiding this comment.
Should we just make this._discovery a Map? They require a tag, it might be easier for checking existence and getting specific ones should we need to do that.
test/peer-discovery/index.spec.js
Outdated
|
|
||
| await libp2p.start() | ||
|
|
||
| expect(libp2p._discovery).to.have.lengthOf(1) |
There was a problem hiding this comment.
We should verify this is the discovery service we expect. Making libp2p. _discovery a map would make this easy to do.
Co-Authored-By: Jacob Heun <jacobheun@gmail.com>
jacobheun
approved these changes
Dec 11, 2019
Co-Authored-By: Jacob Heun <jacobheun@gmail.com>
jacobheun
deleted the
feat/discovery-modules-from-transports-should-be-enabled
branch
jacobheun
added a commit
that referenced
this pull request
Dec 12, 2019
* feat: discovery modules from transports should be added * chore: apply suggestions from code review Co-Authored-By: Jacob Heun <jacobheun@gmail.com> * chore: address review * chore: apply suggestions from code review Co-Authored-By: Jacob Heun <jacobheun@gmail.com>
jacobheun
added a commit
that referenced
this pull request
Jan 24, 2020
* feat: discovery modules from transports should be added * chore: apply suggestions from code review Co-Authored-By: Jacob Heun <jacobheun@gmail.com> * chore: address review * chore: apply suggestions from code review Co-Authored-By: Jacob Heun <jacobheun@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovery modules within Transports automatically added to discovery if enabled