feat: coalescing dial support #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
approved these changes
Dec 15, 2019
src/peer-store/index.js
Outdated
| * @return {PeerInfo} | ||
| */ | ||
| put (peerInfo) { | ||
| put (peerInfo, silent = false) { |
There was a problem hiding this comment.
what do you think on transforming silent in an object? I think it helps to understand in the peerStore.put(peerInfo, true) what the true is
There was a problem hiding this comment.
Sounds good, I refactored and pushed a change to make it take an options object.
vasco-santos
approved these changes
Dec 15, 2019
jacobheun
added a commit
that referenced
this pull request
Jan 24, 2020
* docs: fix spelling in api * fix: dont create peerstore twice * feat: add support for dial coalescing * doc(fix): add setPeerValue to API TOC * docs: add more jsdocs to dialer * chore: remove old comment * fix: ensure connections are closed * fix: registrar.getConnections returns first open conn * fix: directly set the closed status * chore: remove unneeded log * refactor: peerStore.put takes an options object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connectToMultiaddr, all dials now go directly throughconnectToPeerPeerStore.putnow allows you to update a peer without firing thepeerevent. This helps prevent duplicate dialing when dialing a new multiaddr directly. (For example:ipfs swarm connect [addr])