Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String peer ID key mismatch #536

Closed
alanshaw opened this issue Jan 20, 2020 · 1 comment
Closed

String peer ID key mismatch #536

alanshaw opened this issue Jan 20, 2020 · 1 comment
Assignees
@jacobheun
Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/in-progress In progress

Comments

@alanshaw
Copy link
Member

  • libp2p.peerStore.peers.entries() uses peerId.toB58String() for keys
  • libp2p.connections uses peerId.toString() for keys

Please can these be made consistent?
@jacobheun jacobheun self-assigned this Jan 21, 2020
@jacobheun jacobheun added kind/bug A bug in existing code (including security flaws) exp/novice Someone with a little familiarity can pick up status/in-progress In progress P1 High: Likely tackled by core team if no one steps up labels Jan 21, 2020
@jacobheun jacobheun mentioned this issue Jan 21, 2020
Merged
@jacobheun
Copy link
Contributor

Fixed via #537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobheun jacobheun

Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/in-progress In progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alanshaw @jacobheun