Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration option for address listen error tolerance #575

Closed
jacobheun opened this issue Mar 2, 2020 · 1 comment
Closed

Add configuration option for address listen error tolerance #575

jacobheun opened this issue Mar 2, 2020 · 1 comment
Labels
exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@jacobheun
Copy link
Contributor

Problem

Currently if libp2p is provided a list of multiaddrs and there are no valid transports configured for those multiaddrs, libp2p will throw an error on startup and shutdown.

Additionally, if mulitaddrs for an existing transport are provided but listening fails for all multiaddrs for that transport, such as a webrtc-star/etc server being down, libp2p will thrown an error and shutdown.

Solution

We should support the configuration of this tolerance. For some applications it could be perfectly acceptable for nodes to start in dial only mode if all multiaddrs failed for a given transport, or all transports. While libp2p is currently more aggressive with its errors to favor transparency of issues, it shouldn't be restricted to this.

Refs:
@jacobheun jacobheun added kind/enhancement A net-new feature or improvement to an existing feature exp/novice Someone with a little familiarity can pick up status/ready Ready to be worked P2 Medium: Good to have, but can wait until someone steps up labels Mar 2, 2020
@jacobheun jacobheun mentioned this issue Mar 2, 2020
Closed
@mistakia mistakia mentioned this issue Apr 17, 2020
Closed
@vasco-santos vasco-santos mentioned this issue May 19, 2020
Merged
@vasco-santos
Copy link
Member

vasco-santos commented Jun 2, 2020 •
edited
Loading

Closing since #643 was merged and this is being released on libp2p@0.28.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacobheun @vasco-santos