Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear setup/instructions for rendezvous server behind SSL #692

Closed
0xjjpa opened this issue Jul 6, 2020 · 2 comments
Closed

Unclear setup/instructions for rendezvous server behind SSL #692

0xjjpa opened this issue Jul 6, 2020 · 2 comments
Labels
dx Developer Experience kind/bug A bug in existing code (including security flaws) status/ready Ready to be worked

Comments

@0xjjpa
Copy link

0xjjpa commented Jul 6, 2020

  • Version: 0.27.x
  • Platform: nodejs

Type:

Enhancement

Severity:

Very Low

Description:

See libp2p/js-libp2p-webrtc-star#238, libp2p/js-libp2p-webrtc-star#180. In short, for being able to quickly start with the libp2p-in-the-browser demo, one needs to start a signaling start server. Locally, these instructions are pretty clear, but on any other setup (i.e. online demo like Stackblitz or Glitch), this is not obvious, particularly when behind SSL. A warning label in the README would be enough, in addition to the URLs of the existing servers ready to use.

As anadditional note, it would be useful to have a status dashboard for the existing servers (i.e. https://wrtc-star2.sjc.dwebops.pub/, https://wrtc-star1.par.dwebops.pub/) as to know the status of these ones for running demos online.

Steps to reproduce the error:

  1. Clone https://github.com/libp2p/js-libp2p and switch to branch 0.27.x
  2. Go to the libp2p in the browser example.
  3. Change the start function inside package.json from parcel index.html to parcel index.html --https
  4. Run signaling server with npm run server and application with npm run start
  5. Open browser and see mixed content error.
@jacobheun jacobheun added kind/bug A bug in existing code (including security flaws) dx Developer Experience status/ready Ready to be worked labels Jul 7, 2020
@0xjjpa
Copy link
Author

0xjjpa commented Jul 10, 2020

@jacobheun @vasco-santos I've described in libp2p/js-libp2p-webrtc-star#238 how to deploy a wrtc-signaling-star server behind SSL, which can then be used by an online application. To demonstrate this, I went ahead and created a Glitch demo with the libp2p-browser-demo code in this repo using 0.27.x. You can see it running on https://libp2p-browser-demo.glitch.me/ (takes a bit to load, cloud stuff doing p2p stuff, yay).

Glitch has some cool features, like their Remix button which looks something like this:

Remix on Glitch

Clicking on that one will allow anyone in Glitch to create their own “fork” of the project, bringing the “time for demo” to seconds. This setup can likely be replicated in Stackblitz and Codesandbox, but I haven't tried those. I know that @xpepermint from 0xcert used those some time ago (see one of their examples). Maybe we could have more libp2p online demos for beginners?

@maschad
Copy link
Member

maschad commented Sep 28, 2023

Closing as these transports have been deprecated, please migrate to the https://github.com/libp2p/js-libp2p/tree/master/packages/transport-webrtc transport

@maschad maschad closed this as completed Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Developer Experience kind/bug A bug in existing code (including security flaws) status/ready Ready to be worked
Projects
None yet
Development

No branches or pull requests

3 participants