Can dial myself

[a1300]

• Version: v0.29.3
• Platform: Linux
• Subsystem:

Type: Bug

Severity: Medium

Description: I can dial myself

Steps to reproduce the error:

Reproduction gist

git clone https://gist.github.com/a1300/74706c0a7119e0fce1a1cc2366779f1c libp2p-dial-myself
cd libp2p-dial-myself
npm install
node index.js

Output

[0.0.0.0] I am peer "QmZUaDLvgtmaTYgwRcyvd7vXkAEQDXdKhimab6BVwjD7p4"
[0.0.0.0] peer:discovery peer "QmZUaDLvgtmaTYgwRcyvd7vXkAEQDXdKhimab6BVwjD7p4"
(node:27430) ExperimentalWarning: Readable[Symbol.asyncIterator] is an experimental feature. This feature could change at any time
[0.0.0.0] peer:connect peer "QmZUaDLvgtmaTYgwRcyvd7vXkAEQDXdKhimab6BVwjD7p4
[0.0.0.0] peer:connect peer "QmZUaDLvgtmaTYgwRcyvd7vXkAEQDXdKhimab6BVwjD7p4
connections: 1

[a1300]

Related to #356 #274

[vasco-santos]

Well, this was introduced by storing the self peer in the AddressBook. We should get this fixed and verify on the auto dial if we are trying to dial self

[vasco-santos]

Looking into this, we already protect the discovery of self. So, after I checked the provided code I noticed that this is a manual dial to self and not a subsequent dial from discovery.

We should just need to add a check into the dialer connect